refactor and test: addressing C4R issue 22 · valory-xyz/autonolas-tokenomics@660e67c

The following actions uses node12 which is deprecated and will be forced to run on node16: codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v3, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

contracts/interfaces/IUniswapV2Pair.sol#L6

Rule is set with explicit type [var/s: uint]

contracts/Depository.sol#L89

Immutable variables name are set to be in capitalized SNAKE_CASE

contracts/Dispenser.sol#L2

Found more than One contract per file. 6 contracts found!

contracts/Dispenser.sol#L282

Immutable variables name are set to be in capitalized SNAKE_CASE

contracts/Dispenser.sol#L283

Immutable variables name are set to be in capitalized SNAKE_CASE

contracts/Dispenser.sol#L285

Immutable variables name are set to be in capitalized SNAKE_CASE

contracts/Dispenser.sol#L287

Immutable variables name are set to be in capitalized SNAKE_CASE

contracts/Dispenser.sol#L289

Immutable variables name are set to be in capitalized SNAKE_CASE

contracts/GenericBondCalculator.sol#L5

global import of path ./interfaces/ITokenomics.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

contracts/GenericBondCalculator.sol#L6

global import of path ./interfaces/IUniswapV2Pair.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)

deploy/contracts.js#L3

'expect' is assigned a value but never used

deploy/contracts.js#L7

'deployer' is assigned a value but never used

scripts/deployment/staking/arbitrum/bridge_new_token.js#L4

'L1ERC20Gateway' is assigned a value but never used

scripts/deployment/staking/arbitrum/bridge_new_token.js#L5

'L2ERC20Gateway' is assigned a value but never used

scripts/deployment/staking/arbitrum/bridge_new_token.js#L6

'L1ToL2MessageGasEstimator' is assigned a value but never used

scripts/deployment/staking/arbitrum/bridge_new_token.js#L8

'getBaseFee' is assigned a value but never used