chore: scripts to audit on-chain contract setup #79
Conversation
kupermind
commented
Aug 17, 2023
kupermind
commented
- Adding scripts to audit on-chain contract setup.
| @@ -1,1425 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
This ABI is not used anywhere in contracts or setup, it was the intermediary one
| @@ -0,0 +1,14 @@ | |||
| # Source code differences | |||
There was a problem hiding this comment.
This will expand with full report at some point.
| runs: 750, | ||
| runs: 1000000, |
There was a problem hiding this comment.
Restoring the justice!
|
|
||
| // Check quorumNumerator, hardcoded | ||
| const quorumNumerator = await governor["quorumNumerator()"](); | ||
| customExpect(quorumNumerator.toString(), globalsInstance["quorum"], log + ", function: quorumNumerator()"); |
There was a problem hiding this comment.
I would have expected that this and the the following two would have shown an issue. Indeed governorOLAS on goerli have different quorum, initialVotingDelay, initialVotingPeriod. I guess that hardcoded values should be used here
There was a problem hiding this comment.
We compare values with our globals files - they are different for mainnet and goerli. If we want this to be exactly as on the mainnet, we need to use its values then.
There was a problem hiding this comment.
Updated with the mainnet values.
