Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(registry) fix: unitType to update hash for agents and components #85

Merged
merged 8 commits into from
Aug 27, 2024
Merged

(registry) fix: unitType to update hash for agents and components #85

merged 8 commits into from
Aug 27, 2024

Conversation

mohandast52
Copy link
Collaborator

@mohandast52 mohandast52 commented Aug 27, 2024 •
edited
Loading

Fixes

  • The update hash for agents wasn’t working because the unitType was set to “0”. I’ve updated the code to address this and added a constant to prevent the use of hardcoded values in the future.​
  • Removed all duplicate UNIT_TYPES across all the apps and added a single source of truth.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mohandast52 mohandast52 self-assigned this Aug 27, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bond ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 3:25pm
govern ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 3:25pm
launch ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 3:25pm
operate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 3:25pm
registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 3:25pm
tokenomics ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 3:25pm

@mohandast52 mohandast52 added the bug Something isn't working label Aug 27, 2024
@mohandast52 mohandast52 marked this pull request as ready for review August 27, 2024 13:26
@mohandast52 mohandast52 merged commit 218928b into main Aug 27, 2024
10 checks passed
@mohandast52 mohandast52 deleted the mohan/unit-type-fix branch August 27, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kupermind kupermind kupermind approved these changes

@truemiller truemiller truemiller approved these changes

@Tanya-atatakai Tanya-atatakai Tanya-atatakai approved these changes

@oaksprout oaksprout Awaiting requested review from oaksprout oaksprout is a code owner

Assignees

@mohandast52 mohandast52

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mohandast52 @Tanya-atatakai @truemiller @kupermind