(registry) feat: add claiming to unit details #77
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const owners = await contract.methods.getOwners().call(); | ||
|
|
||
| if (Number(threshold) > 0 && owners.length > 0) { | ||
| // TODO: check and fix error: Property 'getStorageAt' does not exist on type 'JsonRpcProvider | FallbackProvider'. |
There was a problem hiding this comment.
pls take a look at this, ts says that there's getStorageAt on provider, but didn't have much time to investigate if it's safe to switch to provider.getStorage or the impact of this. Maybe we should plan the fix 🤔
There was a problem hiding this comment.
I don't remember why I wrote this 🙈, we should definitely plan to fix this.
There was a problem hiding this comment.
if this project uses ethers v6 you need: https://docs.ethers.org/v6/api/providers/#Provider-getStorage
Tanya-atatakai
force-pushed
the
tanya/registry-claim
branch
from
747b25a
to
c44e1cb
Compare
apps/autonolas-registry/common-util/Details/DetailsSubInfo/RewardsSection.tsx
Outdated
Show resolved
Hide resolved
| refetch(); | ||
| fetchPendingIncentives(); |
There was a problem hiding this comment.
maybe await?
| refetch(); | |
| fetchPendingIncentives(); | |
| await refetch(); | |
| await fetchPendingIncentives(); |
There was a problem hiding this comment.
we can run fetchPendingIncentives at the same time when running refetch, no need to wait when it's done, the goal is just to re-request the data. and the result will be recalculated in the rewards useMemo
There was a problem hiding this comment.
Sure, I was concerned that the loader might not be in sync because we're not using await.
apps/autonolas-registry/common-util/Details/DetailsSubInfo/RewardsSection.tsx
Show resolved
Hide resolved
| const owners = await contract.methods.getOwners().call(); | ||
|
|
||
| if (Number(threshold) > 0 && owners.length > 0) { | ||
| // TODO: check and fix error: Property 'getStorageAt' does not exist on type 'JsonRpcProvider | FallbackProvider'. |
There was a problem hiding this comment.
I don't remember why I wrote this 🙈, we should definitely plan to fix this.
apps/autonolas-registry/tests/components/ListAgents/details.test.jsx
Outdated
Show resolved
Hide resolved
apps/autonolas-registry/tests/components/ListComponents/details.test.jsx
Outdated
Show resolved
Hide resolved
Tanya-atatakai
force-pushed
the
tanya/registry-claim
branch
from
70e54e9
to
186b21e
Compare
| const owners = await contract.methods.getOwners().call(); | ||
|
|
||
| if (Number(threshold) > 0 && owners.length > 0) { | ||
| // TODO: check and fix error: Property 'getStorageAt' does not exist on type 'JsonRpcProvider | FallbackProvider'. |
There was a problem hiding this comment.
if this project uses ethers v6 you need: https://docs.ethers.org/v6/api/providers/#Provider-getStorage
@truemiller interesting, thanks! will take a look at it |
Tanya-atatakai
force-pushed
the
tanya/registry-claim
branch
from
288d924
to
da9194c
Compare
Tanya-atatakai
force-pushed
the
tanya/registry-claim
branch
from
da9194c
to
756b7d1
Compare
Proposed changes
getPendingIncentiveslogic (there's no need to get mappers for both agents and components since we pass the unitType)Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply