Support Mode in Registry and Operate #122
Conversation
Tanya-atatakai
requested review from
mohandast52,
oaksprout and
truemiller
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
| @@ -42,6 +59,13 @@ const POLYGON_ADDRESSES: Addresses = { | |||
| operatorWhitelist: '0x526E064cB694E8f5B7DB299158e17F33055B3943', | |||
| }; | |||
|
|
|||
| const MODE_ADDRESSES: Addresses = { | |||
There was a problem hiding this comment.
@kupermind you can verify these addresses
| @@ -59,71 +83,60 @@ const COMMON_TEST_ADDRESSES: Addresses = { | |||
| // TODO: add testcases for all networks | |||
| // get addresses from scripts/deployment folder in autonolas-registries repo | |||
| export const ADDRESSES = { | |||
| 1: MAINNET_ADDRESSES, | |||
There was a problem hiding this comment.
just resorted (placed all test nets at the end) and replaced the numbers with [chain.id] for better readability
| if (!text || text === NA) return NA; | ||
| return <AddressLink {...addressLinkProps} text={text} chainName={chainName} />; | ||
| return <AddressLinkSimple address={record.owner} chainId={chainId} />; |
There was a problem hiding this comment.
the AddressLink from @autonolas/frontend-library creates the url based on the provided chainId, there's no way to pass a custom URL from here. Just simply replaced it with the mono repo's component, so we can see correct scan URL for mode.
| import { RPC_URLS } from 'libs/util-constants/src'; | ||
|
|
||
| const mainnetChain = |
There was a problem hiding this comment.
removed this after Josh's proposal in a previous PR, but not completely - imo it would be easier to switch between prod and test RPCs by simply updating NEXT_PUBLIC_IS_CONNECTED_TO_TEST_NET (once we have a paid tenderly account); however, there might not be a need for this, let's see
There was a problem hiding this comment.
yeah, i agree, or read NODE_ENV development~
..._TEST_NET is a tough one, as there are testnets like Sepolia, Goerli, .etc
either way, thanks for addressing 🙏
| @@ -1,4 +1,5 @@ | |||
| import { EXPLORER_URLS, UNICODE_SYMBOLS } from 'libs/util-constants/src'; | |||
| // eslint-disable-next-line @nx/enforce-module-boundaries | |||
There was a problem hiding this comment.
it's not ideal, but unfortunately I didn't have time to fix it properly, it's a global problem in mono repo, gonna bring it up on the next eng meeting..
There was a problem hiding this comment.
added to the doc, can't remember what the other item was, will DM
| 11155420: COMMON_TEST_ADDRESSES, | ||
| // celo alfajores - testnet for celo | ||
| 44787: COMMON_TEST_ADDRESSES, | ||
| [goerli.id]: { |
There was a problem hiding this comment.
I believe goerli could go for good.
There was a problem hiding this comment.
Same about polygon mumbai
There was a problem hiding this comment.
goerli -> sepolia, polygonMumbai -> polygonAmoy. not urgent at all, but something to fix later.
There was a problem hiding this comment.
yes, one day.... we'll do it
There was a problem hiding this comment.
afaik, goerli RPCs are now all dead and polygon mumbai too.. will add to eng meeting doc
Tanya-atatakai
force-pushed
the
tanya/mode
branch
from
d70736c
to
1117fce
Compare
Tanya-atatakai
force-pushed
the
tanya/mode
branch
from
1117fce
to
bec478b
Compare
Proposed changes
Operate app:
Registry (Tested the whole flow on fork)
Empty list
Service minting
Services
All steps tested
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply