-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues with v2 #102
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: alexisrazok <alexisrazok@users.noreply.github.com>
@jaspervriends what is minimum supported PHP version by this extension? |
…from the database in more places refactor: simplify date formatting using Carbon
This causes a huge performance issue when the discussion contains thousands of posts: flarum-seo/src/Page/DiscussionBestAnswerPage.php Lines 173 to 174 in da3cb93
What would be the preferred approach for handling this - limiting the number of loaded posts or skipping this functionality entirely for discussions with a high post count? I can submit a separate PR once we determine the best solution. Meanwhile, this PR can be merged as it improves other aspects. |
resolves #101