Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TN-3259 research data export - UI not showing the most current download link #4339

Conversation

achen2401
Copy link
Contributor

Address story: TN-3259
See also Slack convo here
Changes include:

  • Whenever an data export is initiated on the UI, the frontend will cache the celery task URL associated with the export
  • Address the scenario where the export is left running in the background, e.g. as when user switches to a different browser tab - when data export window receives focus again, e.g. as when the user comes back from a different browser tab, the frontend will now check if the download has finished by calling the celery task URL cached from the previous step and update the download link on UI if it has finished successfully.
  • other change - enhance error checking

Copy link
Collaborator

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@achen2401 achen2401 changed the base branch from develop to hotfix/correct-type-in-withdrawn-from-study-check September 19, 2023 21:56
@achen2401 achen2401 merged commit d8f2528 into hotfix/correct-type-in-withdrawn-from-study-check Sep 19, 2023
2 checks passed
@achen2401 achen2401 deleted the bugfix/research-data-export-download branch September 19, 2023 21:59
pbugni pushed a commit that referenced this pull request Oct 4, 2023
…ad link (#4339)

Address story:
[TN-3259](https://movember.atlassian.net/browse/TN-3259?atlOrigin=eyJpIjoiM2Q1MzQ2ZjE0YzY1NDBjMDk0OTM2OWMxMWMzMTc3ODAiLCJwIjoiamlyYS1zbGFjay1pbnQifQ)
See also Slack convo
[here](https://cirg.slack.com/archives/C5EU4L7PF/p1694733386101599)
Changes include:
- Whenever an data export is initiated on the UI, the frontend will
cache the celery task URL associated with the export
- Address the scenario where the export is left running in the
background, e.g. as when user switches to a different browser tab - when
data export window receives focus again, e.g. as when the user comes
back from a different browser tab, the frontend will now check if the
download has finished by calling the celery task URL cached from the
previous step and update the download link on UI if it has finished
successfully.
- other change - enhance error checking

---------

Co-authored-by: Amy Chen <clone@cesium.cirg.washington.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants