Feature/deactivate account fix #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ivated patients, if such found, not creating new ones
…wcirg/cosri-patientsearch into feature/deactivate-account-fix
…wcirg/cosri-patientsearch into feature/deactivate-account-fix
…wcirg/cosri-patientsearch into feature/deactivate-account-fix
…wcirg/cosri-patientsearch into feature/deactivate-account-fix
…wcirg/cosri-patientsearch into feature/deactivate-account-fix
pbugni
requested changes
Jan 17, 2024
patientsearch/api.py
Outdated
| and active_patient_flag | ||
| and not is_inactive_search | ||
| ): | ||
| params["active"] = "true" |
There was a problem hiding this comment.
this can just be set to the result of the nested function above.
pbugni
approved these changes
Jan 18, 2024
| del params["inactive_search"] | ||
| elif active_patient_flag: | ||
| params["active"] = "true" | ||
|
|
| @@ -500,12 +577,18 @@ def external_search(resource_type): | |||
| # See if local match already exists | |||
| patient = resource_from_args(resource_type, request.args) | |||
| try: | |||
| internal_bundle = internal_patient_search(token, patient) | |||
| internal_bundle = internal_patient_search( | |||
| token, patient, not reactivate_patient | |||
There was a problem hiding this comment.
using keyword arguments will prevent getting them out of order, and make this easier to read/review. i had to look up internal_patient_search to see what that third parameter is. i.e. active_only=not reactivate_patient
achen2401
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on implementing active boolean field in the Patient as per https://www.pivotaltracker.com/story/show/185455581