Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license and attribution #147

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

mcjustin
Copy link
Member

@mcjustin mcjustin marked this pull request as draft August 15, 2022 23:40
@mcjustin mcjustin requested review from lober and ivan-c August 22, 2022 19:15
@mcjustin mcjustin marked this pull request as ready for review August 22, 2022 19:15
@lober
Copy link
Member

lober commented Aug 22, 2022

I think the idea was to use Apache. I can see the individual changes by right-click-and-open the individual changes, but I don't know if there's a better way to diff all changes in the repo from first to last change? In this case, I think you landed on "University of Washington, School of Nursing" as the copyright holder. I think it's actually just University of Washington

@lober
Copy link
Member

lober commented Aug 22, 2022

But that probably doesn't matter much

@mcjustin
Copy link
Member Author

I think the idea was to use Apache. I can see the individual changes by right-click-and-open the individual changes, but I don't know if there's a better way to diff all changes in the repo from first to last change? In this case, I think you landed on "University of Washington, School of Nursing" as the copyright holder. I think it's actually just University of Washington

@lober since we've decided to use Apache 2.0, and the AHRQ repo also used that, the only change needed for the license itself was to change the templated copyright line in the LICENSE file. I did just edit it to remove the SON reference.

@lober
Copy link
Member

lober commented Aug 22, 2022 via email

Copy link
Member

@lober lober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there still something you want from me on this?

Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this, looks good (keeping as Apache)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants