Skip to content

Commit

Permalink
Set minimum requirements to Java 11 (only for dev) (#255)
Browse files Browse the repository at this point in the history
  • Loading branch information
utarwyn authored Feb 23, 2024
1 parent d617215 commit 6c659c3
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 19 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,30 +16,30 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [ '8', '11', '17' ]
java: [ '11', '17' ]
name: Build with Java ${{ matrix.java }}
steps:
- name: Checkout Git repository
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Restore Gradle cache
uses: actions/cache@v2
uses: actions/cache@v4
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }}
restore-keys: |
${{ runner.os }}-gradle-
- name: Setup JDK ${{ matrix.java }}
uses: actions/setup-java@v2
uses: actions/setup-java@v4
with:
distribution: adopt
java-version: ${{ matrix.java }}

- name: Validate Gradle Wrapper
uses: gradle/wrapper-validation-action@v1
uses: gradle/wrapper-validation-action@v2

- name: Build with Gradle
run: |
Expand All @@ -56,22 +56,22 @@ jobs:
fetch-depth: 0

- name: Restore Gradle cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle*') }}
restore-keys: |
${{ runner.os }}-gradle-
- name: Restore SonarCloud packages
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ~/.sonar/cache
key: ${{ runner.os }}-sonar
restore-keys: ${{ runner.os }}-sonar

- name: Setup JDK 17
uses: actions/setup-java@v3
uses: actions/setup-java@v4
with:
distribution: adopt
java-version: 17
Expand Down
6 changes: 6 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,9 @@ Ready to submit? Perform the checklist below:

Avoid creating too many commits when creating a PR.
Maybe the usage of [`git rebase`](http://learn.github.com/p/rebasing.html) could be a nice idea.

Requirements
------------

- Java 11+
- Gradle 8+
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
plugins {
id 'org.sonarqube'
id 'org.sonarqube' version '4.4.1.3373'
}

group 'fr.utarwyn'
Expand Down
10 changes: 0 additions & 10 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,16 +16,6 @@ dependencyResolutionManagement {
repositoriesMode.set(RepositoriesMode.FAIL_ON_PROJECT_REPOS)
}

buildscript {
repositories {
maven { url 'https://plugins.gradle.org/m2/' }
}
dependencies {
// cannot upgrade to 4.1+ because of Java 8 compatibility
classpath 'org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:4.0.0.2929'
}
}

rootProject.name = 'EnderContainers'

include 'api'
Expand Down

0 comments on commit 6c659c3

Please sign in to comment.