Driver Super での rx frame 取得関数でいかなる場合でも NULL が返らないようにする #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chutaro
approved these changes
Nov 6, 2022
meltingrabbit
force-pushed
the
feature/ds_buffering
branch
from
2aa3ce5
to
09fddc3
Compare
meltingrabbit
force-pushed
the
feature/fix_dssc_get_rx_frame
branch
from
a93d1da
to
736b097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
Driver Super での rx frame 取得関数でいかなる場合でも NULL が返らないようにする
Issue
詳細
see diff
検証結果
既存のテストがすべて通った
影響範囲
とくになし（NULL でフレーム確定判定されていることはない，はず）