Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIDのバリデーションをuser部に移動し， GENERATE_TLM で 2nd OBC の TI, Sequence counter を保存するようにした #353

Merged
merged 4 commits into from
Jun 17, 2022
Merged

APIDのバリデーションをuser部に移動し， GENERATE_TLM で 2nd OBC の TI, Sequence counter を保存するようにした #353

merged 4 commits into from
Jun 17, 2022

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Jun 15, 2022 •
edited
Loading

概要

APIDのバリデーションをuser部に移動し， GENERATE_TLM で 2nd OBC の TI, Sequence counter を保存するようにした

Issue

詳細

tlm id が全OBCでユニークであること，という仮定はまだ外せてない（ので暫定）

検証結果

既存のテストが全て通った

影響範囲

  • APIDのバリデーションを各user で書く必要がある
  • CTP_APID_FROM_ME を各userで定義する必要がある
  • 各OBCのtlmで別のAPIDを割り振るようにする
  • Sequence counterが，MOBCで統一ではなく，各APIDごとになる
  • on board subnet timeはひとまずMOBCのTIを入れる（暫定処置）

@meltingrabbit meltingrabbit self-assigned this Jun 15, 2022
@meltingrabbit meltingrabbit added enhancement New feature or request priority::high priorityg high labels Jun 15, 2022
@meltingrabbit meltingrabbit mentioned this pull request Jun 15, 2022
Merged
3 tasks
yngyu
yngyu reviewed Jun 16, 2022
View reviewed changes
TlmCmd/telemetry_generator.c Outdated Show resolved Hide resolved
@meltingrabbit
Copy link
Collaborator Author

meltingrabbit commented Jun 16, 2022 •
edited
Loading

AE都合で，これから作る，test app をcoreに移植するPRを先にマージしたので，それまでマージは待ちます．

↓
これ

@meltingrabbit meltingrabbit merged commit c55d990 into develop Jun 17, 2022
@meltingrabbit meltingrabbit deleted the feature/user_apid branch June 17, 2022 16:49
@meltingrabbit meltingrabbit mentioned this pull request Jun 17, 2022
Closed
@meltingrabbit meltingrabbit mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yngyu yngyu yngyu approved these changes

@chutaro chutaro Awaiting requested review from chutaro

Assignees

@meltingrabbit meltingrabbit

Labels
enhancement New feature or request priority::high priorityg high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @yngyu