Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order horizontal piping correctly between buildings #679

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Nov 22, 2024

Any background context you want to provide?

Previous code had the correct total length of horizontal piping, but placed them incorrectly between the buildings.

What does this PR accomplish?

Use loop_order file generated by ThermalNetwork to determine the correct order of features, and assign the pipe lengths according to that.

How should this be manually tested?

On develop branch:

  1. Generate a model using the test_district_multi_ghe.py file (no need to simulate)
  2. Review horizontal pipe length list in Modelica model (lDis in tests/model_connectors/output/district_multi_ghe/District/DistrictEnergySystem.mo), which are in meters
  3. Convert meters to feet, and compare the first pipe length with line 1494 of the geojson
  4. Save the lDis output to compare with this branch

On this branch:

  1. Same thing

What are the relevant tickets?

Resolves #674

@vtnate vtnate added the bug Something isn't working label Nov 22, 2024
@vtnate vtnate self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to read pipe lengths starting from the loop start, not the geojson start
1 participant