Makefile fixes #56
Open
Makefile fixes #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the makefile was using those standard variables in an
idiosyncratic way. Normally, one should be able to do something like
this:
make prefix=/opt/uobikiemukot install
Such things didn't work with this makefile.
According the GNU Make documentation, a makefile should never set
DESTDIR. Only the person doing the install should set it.
The prefix variable should be lowercase and default to $(DESTDIR)/usr/local.
The mandir variable is also lowercase and should not be rooted from
DESTDIR. The Make documentation says it should be based on
datarootdir, but that's just $(prefix)/share, so I cut out the
middleman. (I've never seen anyone set datarootdir by hand, but people
set prefix often.)
Previously it had suggested that people edit the makefile to run mkfont_bdf, but that may be less convenient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the variables DESTDIR and prefix in the standard way. Also, recommend that people try glyphbuilder.sh instead of telling people to edit the makefile to change how glyph.h is built.