refactor!: streamline package manager initialization #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jake-ciolek
force-pushed
the
package-manager-init
branch
from
f8d084f
to
a5f93a0
Compare
Create a singleton for the umbrella package manager and use it instead of global package-scoped maps. Use more dependency injection. Move the scattered init() calls to RegisterPackageManager into one place. Create a bootstrap package for handling flag/zip registration. Use the bootstrapping package in main(). Propagate errors up and report them if initialization fails. This should make things a bit more testable in the future. GitHub-Fixes: unikraft#425 Signed-off-by: Jakub Ciolek <jakub@ciolek.dev>
jake-ciolek
force-pushed
the
package-manager-init
branch
from
a5f93a0
to
b134feb
Compare
craciunoiuc
reviewed
Aug 18, 2023
craciunoiuc
reviewed
Aug 18, 2023
|
you might need to refactor some of the tools too, like the Be sure to check them out. |
Good point. It originally broke the github-action, but thankfully the CI caught it. |
4 tasks
nderjung
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Thanks! :)
Reviewed-by: Alexander Jung alex@unikraft.io
Approved-by: Alexander Jung alex@unikraft.io
nderjung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make fmton your commit series before opening this PR;Description of changes
Create a singleton for the umbrella package manager and use it instead of global package-scoped maps. Use more dependency injection.
Move the scattered init() calls to RegisterPackageManager into one place. Create a bootstrap package for handling flag/zip registration.
Use the bootstrapping package in main(). Propagate errors up and report them if initialization fails.
This should make things a bit more testable in the future.
GitHub-Fixes: #425