Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Implement OCI Index manipulation #719

Closed
wants to merge 16 commits into from
Closed

feat!: Implement OCI Index manipulation #719

wants to merge 16 commits into from

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

This PR offers the ability to work with index oci artifacts.
This translates in pushing a single artifact helloworld:latest for multiple platform/architecture permutations.

The outstanding issue of this PR is that containerd support breaks as it still tries to work with images instead of indexes.
Moreover, existing images in the registry might be now unusable and need to be pushed again. Single artifact applications should still have an index.

GitHub-Closes: #704

@craciunoiuc craciunoiuc added kind/enhancement New feature or request cmd/kraft/pkg Issue or PR related to the ukpkg CLI program cmd/kraft/run Issue or PR related to the ukrun CLI program area/manifest Issue or PR is related to the manifest area/oci Issue or PR is related to OCI package management kind/breaking-change Refers to changes that alter the usage of kraftkit labels Aug 9, 2023
@craciunoiuc craciunoiuc marked this pull request as draft August 9, 2023 14:41
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
oci/index.go Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
oci/manager.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
oci/manager.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
cmd/kraft/pkg/pull/pull.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
cmd/kraft/pkg/push/push.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
packmanager/query.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
packmanager/query.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
packmanager/query.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
packmanager/query.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 9, 2023
View reviewed changes
oci/index.go Outdated Show resolved Hide resolved
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-manifest-index-pushing branch 3 times, most recently from 10f0b9d to 0e803c2 Compare August 10, 2023 12:32
nderjung
nderjung reviewed Aug 10, 2023
View reviewed changes
oci/handler/directory.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 10, 2023
View reviewed changes
oci/manager.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 10, 2023
View reviewed changes
oci/pack.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 10, 2023
View reviewed changes
oci/pack.go Outdated Show resolved Hide resolved
nderjung
nderjung reviewed Aug 10, 2023
View reviewed changes
packmanager/query.go Outdated Show resolved Hide resolved
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-manifest-index-pushing branch from 3e2f65d to 24f1162 Compare August 11, 2023 11:55
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-manifest-index-pushing branch 2 times, most recently from ff3ea31 to 31e3c60 Compare September 5, 2023 10:17
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-manifest-index-pushing branch 2 times, most recently from fa20610 to dc244de Compare September 5, 2023 10:29
@craciunoiuc craciunoiuc marked this pull request as ready for review September 5, 2023 10:33
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-manifest-index-pushing branch 2 times, most recently from c8630df to 084c1cd Compare September 8, 2023 12:11
@craciunoiuc @nderjung
feat(packmanager): Add options to specify package characteristics
d9a7416 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(pkg): Specify platform when pulling
a1d697b 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(run): Specify platform when pulling packages
3e67301 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(oci): Add method to package several targets in a single package
c178eef 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat!: Update package managers to support packing multiple components
876a1b7 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(pkg): Package multiple artifacts of a project together
8469e14 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(push): Add option to specify pushing multi-artifact packages
75404a3 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(oci): Add image index structure to handle creating indexes
a3243bc 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(oci): Implement OCI Index structure to wrap over OCI packages
d0b87a9 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(oci): Implement index listing
12d1c4f 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(oci): Filter by platform and add index filtering
915aeb9 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(handler)!: Implement image index interface and adapt existing ones
2071c1c 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(handler)!: Implement index structuring for the directory handler
06e214a 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
feat(handler): Add partially-working implementation for containerd
8105b37 
Currently pulling works. Packaging is not working and pushing can only
push manifests.

Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
fix(oci): Trim OCI prefix when using output argument
08f1f47 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@craciunoiuc @nderjung
REMOVE-ME: °º¤ø,¸¸,ø¤º°°º¤ø,¸
73570cc 
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
@nderjung nderjung force-pushed the craciunoiuc/add-manifest-index-pushing branch from 9abef15 to 73570cc Compare September 8, 2023 16:08
@nderjung nderjung mentioned this pull request Oct 11, 2023
Merged
4 tasks
@craciunoiuc
Copy link
Member Author

This was superseded

@craciunoiuc craciunoiuc deleted the craciunoiuc/add-manifest-index-pushing branch October 17, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nderjung nderjung Awaiting requested review from nderjung

Assignees

@nderjung nderjung

Labels
area/manifest Issue or PR is related to the manifest area/oci Issue or PR is related to OCI package management cmd/kraft/pkg Issue or PR related to the ukpkg CLI program cmd/kraft/run Issue or PR related to the ukrun CLI program kind/breaking-change Refers to changes that alter the usage of kraftkit kind/enhancement New feature or request
Projects
KraftKit Roadmap
Status: 🚀 Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package multiple targets
2 participants
@craciunoiuc @nderjung