Skip to content

Commit

Permalink
fix(qemu): Add pvpanic device only for x86_64 (#720)
Browse files Browse the repository at this point in the history
Reviewed-by: Alexander Jung <alex@unikraft.io>
Approved-by: Alexander Jung <alex@unikraft.io>
  • Loading branch information
nderjung authored Aug 11, 2023
2 parents 2ffc259 + 85eaf9c commit 7e21178
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion machine/qemu/v1alpha1.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ func (service *machineV1alpha1Service) Create(ctx context.Context, machine *mach
}),
WithDisplay(QemuDisplayNone{}),
WithParallel(QemuHostCharDevNone{}),
WithDevice(QemuDevicePvpanic{}),
}

// TODO: Parse Rootfs types
Expand Down Expand Up @@ -399,6 +398,9 @@ func (service *machineV1alpha1Service) Create(ctx context.Context, machine *mach

switch machine.Spec.Architecture {
case "x86_64", "amd64":
qopts = append(qopts,
WithDevice(QemuDevicePvpanic{}),
)
if machine.Spec.Emulation {
qopts = append(qopts,
WithMachine(QemuMachine{
Expand Down

0 comments on commit 7e21178

Please sign in to comment.