Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update getPaymentData method to accept a reference parameter #186

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Freddy10035
Copy link

This is to handle

GuzzleHttp\Exception\ClientException Client error: GET https://api.paystack.co/transaction/verify/ resulted in a 400 Bad Request response: { "status": false, "message": "Transaction ID should be numeric." }

error that people keep on getting when using this with laravel.

@Freddy10035
Copy link
Author

DO NOT MERGE

@chrisidakwo
Copy link

DO NOT MERGE

Is there any reason why this should not be merged?

@unicodeveloper I just came across this issue when trying to verify a payment from a payment page. On successful transaction, the Paystack payment page sends reference as the query param rather than trxref. Hence, either the verifyTransactionAtGateway() method is updated to account for a reference query param or devs are given the option in getPaymentData() to provide the reference however they receive from Paystack - I prefer this option.

@Freddy10035 Pls see my comment on your changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants