-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add info on context registration #5618
base: main
Are you sure you want to change the base?
Conversation
@jemayn Thanks for the PR 😄 Before we review it, could you please make sure the new articles are added in the SUMMARY.md file? That way it will be shown in the navigation 😄 Then we will make sure to review it ASAP 😄 |
Hey @jonat123 I will get them added, I've also been made aware that this has all changed drastically from v12.3 due to umbraco/Umbraco-CMS#14937 so will do some testing and update. Marked it as draft for now pending changes. |
@jemayn What is the status of this PR? Are you still planning on testing and updating the PR? |
@jonat123 it is in a strange state 😅 The PR to obsolete the old way of doing this was merged, but the new way is a lot worse IMO - so we atleast still use the obsolete method. So awaiting umbraco/Umbraco-CMS#15186 atm |
Thanks for letting us know 👍 |
Think we are good to merge this in when umbraco/Umbraco-CMS#15186 gets merged 😁 |
@AaronSadlerUK we still use the obsolete method. Nikolaj has described the way to get the same result currently in this comment: umbraco/Umbraco-CMS#14937 (comment) However, that is not a good solution - and what prompted umbraco/Umbraco-CMS#15186. |
Ah gotcha that makes sense... Although it's rather annoying to do a piece of work knowing I'll have to redo it again soon 😔 |
Description
Added documentation on registering the dbcontext in EF Core and Umbraco for different usecases. Fixes #5595
Type of suggestion
Product & version (if relevant)
Umbraco 12
I've moved the existing database.md article in the root of the Extending section into a new
database
folder and renamed itdatabase-with-npoco.md
while also adding the new info in that same folder asdatabase-with-efcore.md
to keep them seperated.Let me know if anything needs changed, been a while since I kept up with the structure and conventions of the Umbraco Docs 🙂