Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert process initialisation routines to python #3406

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

timothy-nunn
Copy link
Contributor

@timothy-nunn timothy-nunn commented Nov 22, 2024

PROCESS initialisation sequence Fortran -> Python

Iteration variable initialisation sequence Fortran -> Python

initial.f90 post-input pre-model call validation Fortran -> Python

The input validations raise a ProcessValidationError, a new exception introduced specifically for input validation errors in a first move away from the in-built error handling system. As a temporary measure, the non-level 3 errors use warnings.warn until a permanent warning solution is found.

This does mean that our errors and warnings will temporarily operate through two systems, however this is no different how it was in Fortran, with inconsistent use if print/write statements and stop 1 statements.

@timothy-nunn timothy-nunn linked an issue Nov 22, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 72.74678% with 127 lines in your changes missing coverage. Please review.

Project coverage is 29.22%. Comparing base (93bbe4b) to head (694a5ba).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
process/init.py 73.82% 117 Missing ⚠️
process/exceptions.py 50.00% 7 Missing ⚠️
process/main.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3406      +/-   ##
==========================================
+ Coverage   28.36%   29.22%   +0.86%     
==========================================
  Files          77       79       +2     
  Lines       18365    18991     +626     
==========================================
+ Hits         5209     5551     +342     
- Misses      13156    13440     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert PROCESS initialisation routines to Python
2 participants