Fix support for asynchronous plugins in rehypePlugins #670
+79
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to uiwjs#662 Refactor `Markdown` component to support asynchronous plugins. * **Markdown Component (`core/src/components/TextArea/Markdown.tsx`)** - Import `useState` from React. - Add `mdStr` state to manage the processed markdown string. - Refactor `useEffect` to handle asynchronous processing of markdown using `rehype().process`. - Update the return statement to use `mdStr` state. * **Example Component (`www/src/Example.tsx`)** - Import `rehypePrettyCode`. - Add `rehypePrettyCode` to `previewOptions.rehypePlugins`. * **Tests (`test/editor.test.tsx`)** - Add a test to verify that `MDEditor` supports asynchronous plugins. - Use an example async plugin that adds a class to the first node. - Verify that the class is added to the preview node after processing.
|
@vishwamartur is attempting to deploy a commit to the kenny wong's projects Team on Vercel. A member of the Team first needs to authorize it. |
jaywcjlove
reviewed
Nov 1, 2024
| // https://github.com/uiwjs/react-md-editor/issues/593 | ||
| // @ts-ignore | ||
| .use(rehypePrism, { ignoreMissing: true }) | ||
| .process(mdStr) |
There was a problem hiding this comment.
An error occurred in the example. @vishwamartur
jaywcjlove
reviewed
Nov 1, 2024
| @@ -1,5 +1,6 @@ | |||
| import React, { Fragment } from 'react'; | |||
| import rehypeSanitize, { defaultSchema } from 'rehype-sanitize'; | |||
| import rehypePrettyCode from 'rehype-pretty-code'; | |||
There was a problem hiding this comment.
rehype-pretty-code dependency is not included in package.json. @vishwamartur
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #662
Refactor
Markdowncomponent to support asynchronous plugins.Markdown Component (
core/src/components/TextArea/Markdown.tsx)useStatefrom React.mdStrstate to manage the processed markdown string.useEffectto handle asynchronous processing of markdown usingrehype().process.mdStrstate.Example Component (
www/src/Example.tsx)rehypePrettyCode.rehypePrettyCodetopreviewOptions.rehypePlugins.Tests (
test/editor.test.tsx)MDEditorsupports asynchronous plugins.