-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use HPC-stack libraries on WCOSS2 #975
Use HPC-stack libraries on WCOSS2 #975
Conversation
instead of my own personal copy. Fixes ufs-community#877.
test script instead of my personal copy. Fixes ufs-community#877.
script instead of my personal version. Fixes ufs-community#877.
test instead of my own copy. Fixes ufs-community#877.
test instead of my personal version. Fixes ufs-community#877.
instead of my personal copy. Fixes ufs-community#877.
test to fail (large differences). Fixes ufs-community#877.
@DavidHuber-NOAA - would you like to do a quick test in the workflow? |
@DeniseWorthen - on WCOSS2, UFS_UTILS now points to updated libraries. In particular, it now uses ESMF 8.6.0. I think this is why your |
@GeorgeGayno-NOAA Sure, will do. |
On WCOSS2, some
|
Hi George, These look fine. Thanks for checking. All the fields which are reported different have physical ranges >> than the differences so they appear to be just roundoff-level differences. |
@GeorgeGayno-NOAA I tested this PR in the global workflow and compared against the current develop version. I found an unexpected result in the develop version that I do not know how to explain. The half-cycle, 1-hour GDAS forecast produces spurious and fill-valued snow accumulations. However, when using the updated UFS_Utils hash, the snow accumulation values appear to be reasonable. As far as I know, the first half-cycle does not make use of any UFS_Utils executables and the UFS weather model is not cross-linked with UFS_Utils. Is that correct? The output 1-hour GRIB2 files can be found here:
|
Correct. UFS_UTILS is not cross-linked with the UFS weather model. Are the 'anl' or 00-hr forecast files the same? If so, then I can't explain why the 01-hr forecast would be different. |
@GeorgeGayno-NOAA Yes, the 00-hr forecast files are the same. Also, the 1-hour (and all hours thereafter) netCDF outputs are identical between the two runs. It is only the GRIB2 files that differ. It seems this is a reproducibility issue in the inline UPP. I will report this and carry on with my comparison. |
All non-GRIB2 files are identical for the first two full cycles. The only exception are the |
* origin/develop: Update the C192 default ocean resolution in the gdas_init utility (ufs-community#980) Use HPC-stack libraries on WCOSS2 (ufs-community#975) Fix compiler warning in fre-nctools.fd (ufs-community#969) Fix Gnu compilation on Hera (ufs-community#965) Update fixed data directory path for Gaea (ufs-community#972)
DESCRIPTION OF CHANGES:
Update to HPC-stack on WCOSS2. Newer versions of these libraries are now used:
Use the stack version of the
nccmp
utility in the regression tests instead of my own personal copy.TESTS CONDUCTED:
chgres_cube
tests were run on Hercules, Hera, Orion and Jet using 6f42420. All passed as expected.global_cycle
,grid_gen
,weight_gen
,snow2mdl
,ocnice_prep
andice_blend
tests were run on WCOSS2 (using 6f42420). All tests passed.chgres_cube
consistency tests 1/2/3/4/11 and 13 failed (using 6f42420). Differences were noted in the wind fields. However, they were insignificant and likely due to the switch to ESMF 8.6.0. For more details, see: Use HPC-stack libraries on WCOSS2 #975 (comment)cpld_gridgen
andocnice_prep
tests were run on Hera, Hercules, Orion and Jet (using 6f42420). All passed as expected.cpld_gridgen
tests failed (using 6f42420), but the differences from the baseline were small and do not indicate a problem. See: Use HPC-stack libraries on WCOSS2 #975 (comment)DEPENDENCIES:
NOAA-EMC/global-workflow#2106
DOCUMENTATION:
N/A
ISSUE:
Fixes #877.