feat(core): add support for markviews #5759
Open
+201
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
This adds basic support for Prosemirror markviews to
Mark
s.For this to actually become supported we will need to:
From there, we'd pretty much just support them!
Here is what the API looks like right now, but we will probably add a class to make these elements for you:
Implementation Approach
Pretty much following the same sort of implementation as node views, I was able to add support for markviews.
Testing Done
Verification Steps
I added a temporary markview to a mark and it worked just fine
Additional Notes
Checklist
Related Issues