You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the issue where can() check returns false even when the command is actually executable.
Implementation Approach
When chainCommand is executed, multiple commands are run sequentially. The editor state used by later commands may depend on the preceding commands. Therefore, when executing can(), createChain must ensure that shouldDispatch is true to prevent skipping operations on tr.
This fix effectively reverts the code changes from the pull request #3026 and resolves the issue #3025 caused by the clearNodes error.
At the same time, it will also fix issue #3229 and issue #4057.
For more details, please refer to this issue #5721.
Testing Done
In the example default editor, add the disabled attribute to the heading and list action buttons. Before the change, if the cursor was positioned on a heading node, the list action buttons would remain disabled, even though the commands were actually available. After the change, the list action buttons will be displayed as enabled.
Verification Steps
None.
Additional Notes
Checklist
I have created a changeset for this PR if necessary.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Yes, I confirm that I want to close this PR. I reevaluated the situation and created a new PR #5744, adding corresponding test cases to ensure that the changes are correct.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
guanriyue
changed the title
Changes Overview
Fix the issue where
can()check returnsfalseeven when the command is actually executable.Implementation Approach
When
chainCommandis executed, multiple commands are run sequentially. The editor state used by later commands may depend on the preceding commands. Therefore, when executingcan(),createChainmust ensure thatshouldDispatchistrueto prevent skipping operations ontr.This fix effectively reverts the code changes from the pull request #3026 and resolves the issue #3025 caused by the
clearNodeserror.At the same time, it will also fix issue #3229 and issue #4057.
————————————————————————————————————————————————————
For more details, please refer to this issue #5721.
Testing Done
In the example default editor, add the
disabledattribute to the heading and list action buttons. Before the change, if the cursor was positioned on a heading node, the list action buttons would remain disabled, even though the commands were actually available. After the change, the list action buttons will be displayed as enabled.Verification Steps
None.
Additional Notes
Checklist
Related Issues