Sfitz fix plot venn bug #232
Conversation
| MuSE = 'green', | ||
| Strelka2 = 'blue' | ||
| ) | ||
|
|
||
| ## Function: plot venn diagram ##################################################################### | ||
| plot.venn <- function(tool.variants, outfile) { |
There was a problem hiding this comment.
@sorelfitzgibbon
I have adapted your script for plotting and changed some settings of venn.diagram here: https://github.com/uclahs-cds/project-disease-HeadNeckTumor-ATHC-000072-WholeGenomeLandscape/blob/b1c5fe1d7244aeea37ca40bcb4b2b8bd948b3057/analysis_WGS/pipeline/recSNV/consensusVCF/plot.venn.diagram.R#L41
You can check if some of the arguments might be useful to you?
There was a problem hiding this comment.
Worth looking into if any arguments can be used/added
There was a problem hiding this comment.
@maotian06 and I decided nothing needs to be added at this time
…sfitz-fix-plotVenn-bug
|
@yashpatel6 Testing was rerun after merging in main (including merged generic resources branch). Ready to go methinks. |
| MuSE = 'green', | ||
| Strelka2 = 'blue' | ||
| ) | ||
|
|
||
| ## Function: plot venn diagram ##################################################################### | ||
| plot.venn <- function(tool.variants, outfile) { |
There was a problem hiding this comment.
Worth looking into if any arguments can be used/added
Description
plot-venn.R was assuming 4 input algorithms. It's now fixed so it works with any number of algorithms greater than 2.
Testing Results
/hot/code/sfitzgibbon/gitHub/uclahs-cds/pipeline-call-sSNV/test/yaml/a_mini_n2-std-input.yaml/hot/code/sfitzgibbon/gitHub/uclahs-cds/pipeline-call-sSNV/test/config/a_mini-all-tools-except-muse.config/hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-fix-plotVenn-bugChecklist
I have read the code review guidelines and the code review best practice on GitHub check-list.
I have reviewed the Nextflow pipeline standards.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
I have added my name to the contributors listings in the
manifestblock in thenextflow.configas part of this pull request; I am listed already, or do not wish to be listed. (This acknowledgement is optional.)I have added the changes included in this pull request to the
CHANGELOG.mdunder the next release version or unreleased, and updated the date.I have updated the version number in the
metadata.yamlandmanifestblock of thenextflow.configfile following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)I have tested the pipeline on at least one A-mini sample.