-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor heatmaps #73
Conversation
- Tweaked plot parameters - Refactored inputs/aggregate functionality for clearer use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make fixes to this PR
left.padding = 1, | ||
right.padding = 1, | ||
resolution = 3000, | ||
width = 9, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to make the height
and width
customizable since the H:W ratio depends on the number of samples and mutations
|
||
plot.cluster.hm <- function( | ||
cluster.df, | ||
plt.height = 6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll stick to BPG params to simplify things
legend = list(right = list( | ||
fun = legend.ccf | ||
)), | ||
height = 6, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
height
and width
should be customizable
EDIT: Addressed separately in #108 These functions are being picked up as S3 methods for the built-in |
…isualization into danknight-refactor-heatmaps
This PR is split into two PRs to address naming conflicts and standardization of default params |
Description
Closes #...
Checklist
.png
, .jpeg
),.pdf
,.RData
,.xlsx
,.doc
,.ppt
, or other non-plain-text files. To automatically exclude such files using a .gitignore file, see here for example.main
branch protection rule following the github standards before opening this pull request.CHANGELOG.md
under the next release version or unreleased, and updated the date.Pipeline Run Results
Analysis Results