Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sfitz v2.1.2 #18

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Sfitz v2.1.2 #18

merged 6 commits into from
Oct 29, 2024

Conversation

sorelfitzgibbon
Copy link
Collaborator

@sorelfitzgibbon sorelfitzgibbon commented Oct 9, 2024

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number/dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the version number/feature changes in the README.md.

  • I have updated the version number and added my name to the contributors list in the metadata.yaml.

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have drafted the new version release with any additions/changes and have linked the CHANGELOG.md in the release.

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

docker build --no-cache -t testmuse .
docker run --rm testmuse MuSE

output: /hot/code/sfitzgibbon/GitHub/uclahs-cds/docker-MuSE/slurm-230166.out

Closes #10 #16 #17

@wiz-inc-8da00b022c
Copy link

wiz-inc-8da00b022c bot commented Oct 9, 2024

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 0 1 0 1
Vulnerabilities 0 0 0 0 0 0
Sensitive Data 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 0 0 1 0 1

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@yashpatel6 yashpatel6 self-assigned this Oct 10, 2024
@sorelfitzgibbon sorelfitzgibbon changed the title Sfitz v2.1.1 Sfitz v2.1.2 Oct 14, 2024
@sorelfitzgibbon sorelfitzgibbon requested review from yashpatel6 and a team and removed request for yashpatel6 October 14, 2024 17:23
Dockerfile Show resolved Hide resolved
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sorelfitzgibbon sorelfitzgibbon merged commit 20c207c into main Oct 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update PR template
2 participants