Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 2.0.4 #14

Merged
merged 1 commit into from
Nov 13, 2023
Merged

update to 2.0.4 #14

merged 1 commit into from
Nov 13, 2023

Conversation

sorelfitzgibbon
Copy link
Collaborator

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number/dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the version number/feature changes in the README.md.

  • I have updated the version number and added my name to the contributors list in the metadata.yaml.

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have drafted the new version release with any additions/changes and have linked the CHANGELOG.md in the release.

Docker Hub Auto Build Rules

  • I have created automated build rules following this page and I have not manually pushed this Docker image to the blcdsdockerregistry on Docker Hub.

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Testing

Test script runs MuSE call and MuSE sump and compares output with expected. Tests passed if file error-if-no-empty is empty
sbatch --partition F16 --cpus-per-task 4 --mem 8G /hot/software/image/docker-MuSE/Docker/development/test-files/runTestMuse.sh
output: /hot/software/image/docker-MuSE/Docker/development/unreleased/sfitz-update-to-2.0.4
log:/hot/software/image/docker-MuSE/Docker/development/unreleased/sfitz-update-to-2.0.4/slurm-77902.out

Description

Update to version 2.0.4, hopefully fixing the error causing MuSE call to sporadically hang up indefinitely. https://github.com/wwylab/MuSE/releases/tag/v2.0.4

Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sorelfitzgibbon sorelfitzgibbon merged commit 4f6135b into main Nov 13, 2023
1 check passed
@sorelfitzgibbon sorelfitzgibbon deleted the sfitz-update-to-2.0.4 branch November 13, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants