Fix build and add custom parameterization (#24) #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add battenberg.R for customization
add max.rho to battenberg_bl_custom.R
add max rho default
add custom battenberg wrapper
add max rho to wrapper
add max rho to wrapper
add max rho to wrapper
use battenberg.R from v2.2.9 and add max.rho
rename battenberg_wgs.R battenberg_wgs_bl_custom.R
resolve merge conflict again
Add renv.lock file containining R package versions
remove modify_reference_path.sh
resolve merge conflict in Dockerfile
resue ascat/battenberg version arg
Update CHANGELOG.md
Update changes
commit to remove installer.R
specify removal of files under /usr/local/src/
verify checksum and set up workdir
update CHANGELOG
Update license year
Description
Closes #...
Testing Results
Docker Image Testing
docker run
command as described below.Test the Docker image with at least one sample. Verify the new Docker image works using:
docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>
My command:
Provide the command you ran here
Test Cases
Checklist
Formatting
I have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
File Updates
I have ensured that the version number update follows the versioning standards.
I have updated the version number in the
Dockerfile
,README.md
andmetadata.yaml
files.I have updated the dependencies and added my name to the maintainer list in the
Dockerfile
.I have updated the feature changes in the
README.md
(optional).I have added the changes included in this pull request to the
CHANGELOG.md
under the next release version or unreleased, and updated the date.GitHub Packages Auto Build Rules
I have not manually pushed this Docker image to the uclahs-cds container registry (
ghcr.io/uclahs-cds
) on GitHub.I have updated the
image_name
in themetadata.yaml
which is required by GitHub action to automatically build and push the image.