Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build and add custom parameterization (#24) #26

Closed
wants to merge 1 commit into from

Conversation

Faizal-Eeman
Copy link
Contributor

  • add battenberg.R for customization

  • add max.rho to battenberg_bl_custom.R

  • add max rho default

  • add custom battenberg wrapper

  • add max rho to wrapper

  • add max rho to wrapper

  • add max rho to wrapper

  • use battenberg.R from v2.2.9 and add max.rho

  • rename battenberg_wgs.R battenberg_wgs_bl_custom.R

  • resolve merge conflict again

  • Add renv.lock file containining R package versions

  • remove modify_reference_path.sh

  • resolve merge conflict in Dockerfile

  • resue ascat/battenberg version arg

  • Update CHANGELOG.md

  • Update changes

  • commit to remove installer.R

  • specify removal of files under /usr/local/src/

  • verify checksum and set up workdir

  • update CHANGELOG

  • Update license year


Description

Closes #...

Testing Results

Docker Image Testing

  • I have tested the Docker image with the docker run command as described below.

Test the Docker image with at least one sample. Verify the new Docker image works using:

docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>

My command:

Provide the command you ran here

Test Cases

  • Case 1
    • sample:
    • input csv:
    • config:
    • output:
  • Case 2
    • sample:
    • input csv:
    • config:
    • output:

Checklist

Formatting

File Updates

  • I have ensured that the version number update follows the versioning standards.

  • I have updated the version number in the Dockerfile, README.md and metadata.yaml files.

  • I have updated the dependencies and added my name to the maintainer list in the Dockerfile.

  • I have updated the feature changes in the README.md (optional).

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

GitHub Packages Auto Build Rules

  • I have not manually pushed this Docker image to the uclahs-cds container registry (ghcr.io/uclahs-cds) on GitHub.

  • I have updated the image_name in the metadata.yaml which is required by GitHub action to automatically build and push the image.

* add battenberg.R for customization

* add max.rho to battenberg_bl_custom.R

* add max rho default

* add custom battenberg wrapper

* add max rho to wrapper

* add max rho to wrapper

* add max rho to wrapper

* use battenberg.R from v2.2.9 and add max.rho

* rename battenberg_wgs.R  battenberg_wgs_bl_custom.R

* resolve merge conflict again

* Add renv.lock file containining R package versions

* remove modify_reference_path.sh

* resolve merge conflict in Dockerfile

* resue ascat/battenberg version arg

* Update CHANGELOG.md

* Update changes

* commit to remove installer.R

* specify removal of files under /usr/local/src/

* verify checksum and set up workdir

* update CHANGELOG

* Update license year

---------

Co-authored-by: Mootor <mmootor@ip-0A125937.rhxrlfvjyzbupc03cc22jkch3c.xx.internal.cloudapp.net>
@wiz-inc-8da00b022c
Copy link

Wiz Scan Summary

Scan Module Critical High Medium Low Info Total
IaC Misconfigurations 0 0 17 2 0 19
Vulnerabilities 0 0 0 0 0 0
Sensitive Data 0 0 0 0 0 0
Secrets 0 0 0 0 0 0
Total 0 0 17 2 0 19

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant