-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build and add custom parameterization #24
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
I also realized, we'd have to make a sub-branch off of this branch in order to release |
e91b528
to
9501b92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments but otherwise looks good. Anything else from @tyamaguchi-ucla ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally ok with building from this, anything else to add from @tyamaguchi-ucla ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! We can update the copyright year range and merge the branch into main.
README.md
Outdated
@@ -65,7 +72,7 @@ Author: 'Mohammed Faizal Eeman Mootor', 'Ardalan Davarifar' | |||
|
|||
docker-Battenberg is licensed under the GNU General Public License version 2. See the file LICENSE for the terms of the GNU GPL license. | |||
|
|||
docker-Battenberg can be used to create a docker instance to use the Battenberg tool. | |||
docker-Battenberg can be used to create a docker instance to use the Battenberg tool. | |||
|
|||
Copyright (C) 2021-2023 University of California Los Angeles ("Boutros Lab") All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright (C) 2021-2023 University of California Los Angeles ("Boutros Lab") All rights reserved. | |
Copyright (C) 2021-2024 University of California Los Angeles ("Boutros Lab") All rights reserved. |
I can't believe it's almost 2025..!
Description
renv.lock
filebattenberg.R
andbattenberg_wgs.R
Closes #23
Testing Results
Docker Image Testing
docker run
command as described below.Test the Docker image with at least one sample. Verify the new Docker image works using:
docker run -u $(id -u):$(id -g) –w <working-directory> -v <directory-you-want-to-mount>:<how-you-want-to-mount-it-within-the-docker> --rm <docker-image-name> <command-to-the-docker-with-all-parameters>
My command:
Test Cases
Checklist
Formatting
I have read the code review guidelines and the code review best practice on GitHub check-list.
The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].
I have set up or verified the branch protection rule following the github standards before opening this pull request.
File Updates
I have ensured that the version number update follows the versioning standards.
I have updated the version number in the
Dockerfile
,README.md
andmetadata.yaml
files.I have updated the dependencies and added my name to the maintainer list in the
Dockerfile
.I have updated the feature changes in the
README.md
(optional).I have added the changes included in this pull request to the
CHANGELOG.md
under the next release version or unreleased, and updated the date.GitHub Packages Auto Build Rules
I have not manually pushed this Docker image to the uclahs-cds container registry (
ghcr.io/uclahs-cds
) on GitHub.I have updated the
image_name
in themetadata.yaml
which is required by GitHub action to automatically build and push the image.