-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partial scoring for pick-all questions #2020
base: dev/33-serpierite
Are you sure you want to change the base?
Partial scoring for pick-all questions #2020
Conversation
While I see this as a clear improvement, it does change the way assessments are graded which could have unintended consequences on grade review. For example if a student took an assessment before this update and got no credit for a 'select all that apply' question, then go back to review that assessment score after this update goes into effect, do they still see the 0% for that question, or does the partial credit calculation say they should have received credit? I can also imagine a scenario where authors want a multi-select question that specifically grants a 0% if the student does not select all possible correct answers. Is that readily possible? If not, MC questions would need some kind of a toggle which defaults to the old behavior so everything stays backwards compatible. |
It looks like previous attempt scores are correctly showing 0% for a partially incorrect question, if the assessment was taken without partial scores. That's a good point about allowing authors to choose whether they want partial scoring or not though, I'll work on adding a toggle for it. |
… if the question type is 'multiple choice' and the response type is 'pick all'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find any gotchas, and everything looks good and seems to be working well. Approved based on that.
I added a last-minute bit of logic to only show the 'partial credit' toggle when the question is a MC type and the 'choose all correct answers' option is chosen since it didn't make sense to make a whole new issue. Little awkward approving my own work, so another set of eyes on it just to make sure I didn't miss anything would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checkout this out and it all looks good on all browsers. Button to toggle partial scoring only appears when it is suppost to and works well. Scoring looks good and the code is clean.
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…icts and fixed test breakage. Fixed sudden stylelint violations.
I spent some time creating different scenarios in assessments and manually checking the math of the score and it looks good. I didn't find any issues with the scoring. |
Resolves #545
MC questions that are pick-all should now calculate their scores based on how many correct/incorrect options were chosen, instead of being all-or-nothing.