-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS packaging for verification functions #111
Draft
bgins
wants to merge
18
commits into
main
Choose a base branch
from
bgins/add-js-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare workers use the workerd key.
Use playwright-tests for browser tests instead of vitest. It is currently more stable than vitest for browser testing. Convert tests from expect to assert for a purely JS implementation. Unify tests into a single module which is loaded by each environment after import and initialization (where required). Add coverage. Write coverage and test results for each environment to JSON files.
bgins
force-pushed
the
bgins/add-js-support
branch
from
July 5, 2023 21:45
cf69289
to
a3c8aef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that still needs work! It's open to initial feedback, but see the remaining tasks section to get an idea of what needs to be implemented.
Description
This PR implements the following features:
checkSignature
,decode
,isExpired
,isTooEarly
,toCID
,validate
functionsucan-wasm
crate with JavaScript packaging supportbrowser
,node
,deno
, andworkerd
targets (workerd
is Cloudflare workers)Link to issue
Implements #93
Type of change
Test plan (required)
The test suite includes unit tests for each function. Tests read from a set of fixtures written in the style of the spec repo fixtures (https://github.com/ucan-wg/spec/tree/main/fixtures/0.8.1) but upgraded to UCAN 0.9.0. (Side note: It would be nice to eventually add these to the spec repo and pull them from there.)
The tests are run in
node
and headless browser environments includingchromium
,firefox
, andwebkit
.Remaining tasks
rs-ucan/ucan-wasm/src/ucan/verify.rs
Lines 15 to 19 in 8520742
deno
testsworkerd
tests (if possible)