cleanup: Use const values to handle layout / entries well known values and generate strings instead of hardcoding them #626
Commits on Nov 26, 2024
-
brokers: Move auth results to auth package so that can be used everyw…
…here We were duplicating this in the example broker, so let's make the same content be available everywhere.
-
cleanup: Define layout type names as constants and reuse them in code
Avoid (re)using string values for layout types as is, since they are prone to errors and they're hard to maintain.
-
cleanup: Define entries names as constants and reuse them in code
Avoid (re)using string values for entries types as is, since they are prone to errors and they're hard to maintain.
-
brokers/layouts: Add simple formatter for optional/required items
Avoid building the list manually now that we've consts values and use this for both optional booleans and supported entries
-
brokers/layouts: Add parser for joined layout items
It can be used to parse optional or required values or entries. Use this both in broker and example brokers logic
-
cleanup: Use layouts.True instead of strings
Avoid repeating the same string allover the places
-
-
-
examplebroker: Simplify auth modes handling by using a maps of structs
We were using a maps of maps that made code hard to read and maintain and doing some unneeded conversions to json back and forth. Avoid this by just using structured data instead
-
examplebroker: Define authentication modes we support globally
So that we can reuse their ID across the file without further constants
-
-
-
cleanup: Move authd protocol definitions to internal library
We don't need to expose the proto externally, since we are now re-usable so if something of it has to be exposed we should do it manually
-
services/pam: Set qrcode rendering to false if the flag is false
It's what the oidc broker expects to be set in case the rendering is not supported, while we were unsetting the value by default.
-
brokers/layouts: Add functions to create UILayout definitions and par…
…se them We use to create UI options manually and converting them to maps for being transferred via DBus, it's something we also need to do in the broker side, so let's expose this publicly for being reused by brokers too
-
brokers/layouts: Do not include unset values on string maps objects
If some values are unset, there's no point to expose them to the brokers
-
cleanup: Use layouts to create layouts for tests
Now that it has been tested with the manually generated version we can use the utility functions.
-
-
brokers/layouts: Add simple functions to parse lists of layout maps
It can be useful for brokers to handle the received messages
-
examplebroker: Use native layouts.UILayout to parse the supported UI …
…layouts It adds a convenient way to handle the value as a native type.
-
brokers/auth: Add authentication Mode abstraction utilities
These can be used by brokers and authd to parse the results back and forth from the dbus format.
-
-
examplebroker: Move to internal package
Now that authd can be imported we should not expose anything that isn't an API.
