-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tab name and portlet info to analytics events #2694
feat: add tab name and portlet info to analytics events #2694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bjagg! looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like ESLint may need a configuration update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bjagg - Fixed the package lock conflict and confirmed the new details are being sent in the request locally.
Seems a bit odd that the tab_name
is scraping the text content. It's ending up with values such as tab_name: "TestingEdit text Testing"
. If this is as-intended, then 👍
Confirmed that layering the commits from #2695 onto this code persists the new fields.
Checklist
security.properties
portal.properties
CHANGES.md
Description of change
Add tab (name) and portlet info (ID and title) to analytics events.