Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update person directory to v1.8.16 #2280

Merged
merged 7 commits into from
Sep 10, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 11, 2021

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
org.apereo.service.persondir:person-directory-api (source) 1.8.11 -> 1.8.16 age adoption passing confidence
org.apereo.service.persondir:person-directory-impl (source) 1.8.11 -> 1.8.16 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/person-directory branch from 295c729 to d6eff1e Compare August 6, 2021 22:23
@renovate renovate bot changed the title chore(deps): update person directory to v1.8.16 chore(deps): update person directory to v1.8.16 - autoclosed Aug 12, 2021
@renovate renovate bot closed this Aug 12, 2021
@renovate renovate bot deleted the renovate/person-directory branch August 12, 2021 12:14
@renovate renovate bot changed the title chore(deps): update person directory to v1.8.16 - autoclosed chore(deps): update person directory to v1.8.16 Aug 13, 2021
@renovate renovate bot reopened this Aug 13, 2021
@renovate renovate bot restored the renovate/person-directory branch August 13, 2021 13:52
@renovate renovate bot force-pushed the renovate/person-directory branch from d6eff1e to c4b3976 Compare August 30, 2021 08:44
@renovate renovate bot force-pushed the renovate/person-directory branch from c4b3976 to 4f60e53 Compare October 12, 2021 04:21
@renovate renovate bot force-pushed the renovate/person-directory branch 2 times, most recently from d5d46e4 to f8ea90a Compare November 22, 2021 03:33
@renovate renovate bot force-pushed the renovate/person-directory branch from f8ea90a to dabdbbf Compare May 23, 2022 22:16
@renovate renovate bot changed the title chore(deps): update person directory to v1.8.16 chore(deps): update Person Directory to v1.8.16 Jun 27, 2022
@renovate renovate bot changed the title chore(deps): update Person Directory to v1.8.16 chore(deps): update person directory to v1.8.16 Jun 28, 2022
@renovate renovate bot force-pushed the renovate/person-directory branch 4 times, most recently from fd77301 to 632d0cc Compare July 18, 2022 20:16
@renovate renovate bot changed the title chore(deps): update person directory to v1.8.16 fix(deps): update person directory to v1.8.16 Jul 27, 2022
@renovate renovate bot force-pushed the renovate/person-directory branch from 632d0cc to b62642e Compare August 23, 2022 17:30
@renovate renovate bot force-pushed the renovate/person-directory branch from b62642e to 9786082 Compare September 1, 2022 17:52
@renovate renovate bot force-pushed the renovate/person-directory branch from 9786082 to f9df188 Compare October 5, 2022 19:13
@renovate renovate bot force-pushed the renovate/person-directory branch from f9df188 to 85c70e5 Compare October 24, 2022 02:01
@renovate renovate bot force-pushed the renovate/person-directory branch from 85c70e5 to 643b431 Compare November 30, 2022 16:14
@renovate renovate bot force-pushed the renovate/person-directory branch from 643b431 to 0132828 Compare December 16, 2022 03:43
@renovate renovate bot changed the title fix(deps): update person directory to v1.8.16 Update Person Directory to v1.8.16 Dec 17, 2022
@renovate renovate bot changed the title Update Person Directory to v1.8.16 fix(deps): update person directory to v1.8.16 Dec 17, 2022
@renovate renovate bot force-pushed the renovate/person-directory branch from 0132828 to 44740be Compare January 26, 2023 17:34
@renovate renovate bot force-pushed the renovate/person-directory branch from 44740be to a3fed1d Compare February 11, 2023 10:26
@renovate renovate bot changed the title Update Person Directory to v1.8.16 fix(deps): update person directory to v1.8.16 Aug 10, 2023
@renovate renovate bot force-pushed the renovate/person-directory branch from d441db5 to 80cc25e Compare August 22, 2023 17:44
@renovate renovate bot changed the title fix(deps): update person directory to v1.8.16 Update Person Directory to v1.8.16 Aug 22, 2023
@renovate renovate bot changed the title Update Person Directory to v1.8.16 fix(deps): update person directory to v1.8.16 Oct 26, 2023
@renovate renovate bot force-pushed the renovate/person-directory branch 3 times, most recently from 447ce1e to 325b88b Compare November 11, 2023 01:57
@renovate renovate bot force-pushed the renovate/person-directory branch from 325b88b to 283a465 Compare November 16, 2023 11:37
@renovate renovate bot force-pushed the renovate/person-directory branch from 283a465 to 621d242 Compare February 8, 2024 18:58
@renovate renovate bot force-pushed the renovate/person-directory branch from 621d242 to bac42e8 Compare March 21, 2024 03:45
@renovate renovate bot force-pushed the renovate/person-directory branch from bac42e8 to 4a234aa Compare June 17, 2024 15:24
Copy link
Contributor Author

renovate bot commented Aug 8, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@Naenyn
Copy link
Contributor

Naenyn commented Aug 8, 2024

I've updated the code to handle the upstream person directory changes. However, for the time being, the "filter" that a handful of the methods now take as an argument is passed in as null. This will need to be updated if we want to do anything interesting with that filter.

@Naenyn Naenyn requested review from bjagg and groybal August 8, 2024 16:25
bjagg
bjagg previously requested changes Aug 26, 2024
Copy link
Member

@bjagg bjagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of rolled up commits. Can you see if rebasing to the main branch eliminates commits, please?

@Naenyn Naenyn requested a review from bjagg September 4, 2024 21:19
@Naenyn Naenyn closed this Sep 4, 2024
@Naenyn Naenyn reopened this Sep 4, 2024
@Naenyn Naenyn dismissed bjagg’s stale review September 4, 2024 21:21

I took a shot at it. Not sure things are any better, though. Take another look?

Copy link
Member

@bjagg bjagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pulled down changes and did some light testing. Test users continue to have the same groups and attributes. 🎖️

@bjagg bjagg merged commit a7b86aa into master Sep 10, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants