CSS: Add a debugger class. #40976
+82
−2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| @if $enable-debugger-classes { | ||
| .#{$prefix}grid-debug { | ||
| &::before { | ||
| position: fixed; | ||
| top: 0; | ||
| left: 0; | ||
| z-index: 2000; | ||
| padding: $spacer * .5 $spacer; | ||
| font-family: $font-family-base; | ||
| color: $black; | ||
| background-color: $white; | ||
| border-radius: 0 0 4px; // stylelint-disable-line property-disallowed-list | ||
| @include font-size($h1-font-size); | ||
|
There was a problem hiding this comment. can this get font size from css a variable? then we may able to adjust it like |
||
| } | ||
|
|
||
| @each $breakpoint, $value in $grid-breakpoints { | ||
| @include media-breakpoint-up($breakpoint) { | ||
| &::before { | ||
| content: "#{$breakpoint}"; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| [class^="container"], | ||
|
There was a problem hiding this comment. Can you provide this functionality as a seperated class name? There was a problem hiding this comment. Why not, I don't have strong opinion on this. I did it this way because on my project, we use sometimes There was a problem hiding this comment. This feature looks nice but the developer may want to toggle on/off this option to make the design look more clear and understandable. You know, design considerations call for pixel-perfect work, and the overlay of this option can become annoying at some point.
It would be better if it does not have any connection with the other class name. The developer can use whatever he/she wants like |
||
| &[class^="container"], | ||
| .row, | ||
| &.row { | ||
| position: relative; | ||
|
|
||
| &::before { | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| bottom: 0; | ||
| left: 0; | ||
| z-index: 1999; | ||
| pointer-events: none; | ||
| content: ""; | ||
| background: repeating-linear-gradient(to right, transparent, transparent calc(var(--#{$prefix}gutter-x) * .5), var(--#{$prefix}primary) calc(var(--#{$prefix}gutter-x) * .5), var(--#{$prefix}primary) calc((100% - 12 * var(--#{$prefix}gutter-x)) / 12 + var(--#{$prefix}gutter-x) * .5), transparent calc((100% - 12 * var(--#{$prefix}gutter-x)) / 12 + var(--#{$prefix}gutter-x) * .5), transparent calc(100% / 12)); // stylelint-disable-line function-disallowed-list | ||
| opacity: .3; | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| $enable-debugger-classes: true !default; | ||
|
|
||
| @import "functions"; | ||
| @import "variables"; | ||
| @import "mixins"; | ||
|
|
||
| @import "debug"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -58,5 +58,6 @@ $utilities: map-get-multiple( | |
| "padding-start", | ||
| ) | ||
| ); | ||
| @import "debug"; | ||
|
|
||
| @import "utilities/api"; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,6 +46,7 @@ | |
|
|
||
| // Helpers | ||
| @import "helpers"; | ||
| @import "debug"; | ||
|
|
||
| // Utilities | ||
| @import "utilities/api"; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this use em unit instead of rem unit for padding? Then it may adjust itself by its font size.