-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix align SVG icon with text in masthead notice #40897
base: main
Are you sure you want to change the base?
Fix align SVG icon with text in masthead notice #40897
Conversation
@julien-deramond Hi Julien I see that some checks were not successful. Do I need to refactor and then commit directly in these? |
Indeed, there's a linting issue in https://github.com/twbs/bootstrap/actions/runs/11147229051/job/30983805715?pr=40897. You can run |
Thank you for your response. I have fixed the Stylelint issue. Hopefully, the linting will be successful now. 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes and I'll be fine on my side.
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
Co-authored-by: Louis-Maxime Piton <louismaxime.piton@orange.com>
Description
The SVG icon (arrow right) was not aligned correctly with the masthead notice text when the screen size became smaller than 576px because the class
d-sm-inline-flex
is used, which removes thedisplay: inline-flex;
when the screen size is below 576px. But this needed to be removed because when the masthead notice breaks to a new line, the entire element looks weird. Therefore, I came with a slightly different solution that resolved the issue.Before:
Screen size ≥576px
Screen size <576px
After:
Screen size ≥576px
Screen size <576px
Motivation & Context
align-items-center
andgap-1
classes only worked when thed-sm-inline-flex
class was active. When the screen size is smaller than 576px,d-sm-inline-flex
class is removed, which leaves unused styles in the file and makes it bigger for no reason. The new solution avoids this.Type of changes
Checklist
npm run lint
)Live previews
Related issues