[desktop/linux] propagate keytar cancellation from KeytarSecretStorage #3773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganthern
force-pushed
the
keytar-cancellation-3733
branch
from
9b3cefa
to
9162ead
Compare
charlag
force-pushed
the
keytar-cancellation-3733
branch
from
9162ead
to
7504e8b
Compare
charlag
approved these changes
Jan 13, 2022
3 tasks
ganthern
force-pushed
the
keytar-cancellation-3733
branch
from
7504e8b
to
f381aab
Compare
ganthern
force-pushed
the
keytar-cancellation-3733
branch
from
f381aab
to
7eff460
Compare
charlag
force-pushed
the
keytar-cancellation-3733
branch
from
7eff460
to
1c6fbad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes missing cancellation in keytar #3733
with this, the user will get an error box "Can't access secret storage" with a reference to the secret storage FAQ if they cancel the keychain unlock.