sqld: enable updating max_row_size in namespace config #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OwenDelahoy
force-pushed
the
main
branch
4 times, most recently
from
1a1a2b7
to
beecde0
Compare
OwenDelahoy
changed the title
OwenDelahoy
force-pushed
the
main
branch
3 times, most recently
from
8d2a360
to
294144e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that while
max_row_sizecan be specified during namespace creation, it can not be modified afterwards.Is this a simple oversight or is there a deeper reason?
Under the assumption it is a simple oversight I have added it to the
/v1/namespaces/:namespace/configroute post handler.Feedback welcome, Thank you.