Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend Developer Challenge #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Frontend Developer Challenge #8

wants to merge 4 commits into from

Commits on Jan 11, 2021

  1. -Added isPinned tracked property on the application index route sin… 

    …ce the controllers are singleton.

- Added `togglePin` action on controller to provide a way for user to toggle pinned tasks. (Passed in to component as children attribute)
    @0xMurage
    0xMurage committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    443006b View commit details
    Browse the repository at this point in the history

  2. - Refactored the index template to utilize pinnedTasks computed pro… 

    …perty from the filtered model, leading to re-usability of `TaskList` component.

- Introduced computed property for `unpinned tasks` in the index controller.
    @0xMurage
    0xMurage committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    61a3c32 View commit details
    Browse the repository at this point in the history

  3. - Added computed property on index controller to calculate number of … 

    …completed tasks
    @0xMurage
    0xMurage committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    2c6ffa0 View commit details
    Browse the repository at this point in the history

  4. - To minimize bugs, promote re-usability and DRY principle, the toggl… 

    …e button should not modify the data directly through actions. The action should reside on SingleTask component layer since it owns the data.
    @0xMurage
    0xMurage committed Jan 11, 2021
    Configuration menu
    Copy the full SHA
    b8295e7 View commit details
    Browse the repository at this point in the history