Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vulnerable request dep #152

Closed
wants to merge 16 commits into from
Closed

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jul 21, 2023

request is deprecated and has known vulnerabilities. Remove the dependency.

Closes #103
Closes #91

@sirreal sirreal changed the base branch from master to 4.0.0-alpha July 21, 2023 14:27
sanmai
sanmai previously approved these changes Jul 22, 2023
Copy link
Member

@sanmai sanmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow CI is passing without it, so I guess we don't need it 🤔

@sirreal sirreal dismissed sanmai’s stale review July 24, 2023 07:43

Not ready for merge

Update jsdoc dep
Switch from hotdoc to docdash
Compile gh-pages directory
@sirreal sirreal force-pushed the 4.0.0-alpha branch 7 times, most recently from 7e6ff21 to 579e908 Compare August 1, 2023 14:26
@sirreal
Copy link
Member Author

sirreal commented Aug 16, 2023

Superseded by #153

@sirreal sirreal closed this Aug 16, 2023
@sirreal sirreal deleted the js/remove-request-dep branch August 16, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request is deprecated for a year. request js has been deprecated
2 participants