fixed: room tags event listening #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tags are on the room level, and the room level account data filter already includes that. It sounds like a server bug if it's not reading the filter correctly |
|
Yeah I saw that, but that did not match anything for me. I'm on latest dendrite master. The weird thing is that tags are perfectly visible on other clients like Nheko. |
|
Sounds like a dendrite bug then 🤔 Should probably make sure it works on synapse and then file an issue with dendrite |
|
huh.. the latest master changes seem to fix my issue. that's weird |
|
Ok no it doesn't. All tags are gone after /sync without my patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been a little while that room tag were not working for me. I was able to add some (visible in other clients like nheko) but gomuks never got them back.
After hacking around it seemed that the generated JSON filter (which from what I understand is a way to only ask to be notified for particular events) was not correct. This simple patch fixes all the room tags issues I had.
I'm not sure if this is an elegant fix though. Please let me know