refactor: align ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES with the Xcode default #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
fortmarek
reviewed
Nov 13, 2024
| @@ -373,10 +373,6 @@ public class BuildSettingsProvider { | |||
|
|
|||
| private static func targetSwiftSettings(platform: Platform, product: Product) -> BuildSettings { | |||
There was a problem hiding this comment.
I believe the method can be removed completely now
There was a problem hiding this comment.
@fortmarek I agree. Removed it!
fortmarek
changed the title
fortmarek
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves tuist/tuist#6989
Short description 📝
I modified BuildSettingsProvider.swift to resolve issue 6989 of tuist/tuist.
Removed the settings for ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES so that tuist always followed the default settings of Xcode.
Please see this issue.
Solution 📦
tuist/tuist depends on local XcodeProj. Modified local XcodeProj and then test at fixtures/workspace_with_test_locale.
Implementation 👩💻👨💻