Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inconsistent behaviour with Xcode 16 when PBXProject.TargetAttributes is empty #865

Merged

Conversation

Speakus
Copy link
Contributor

@Speakus Speakus commented Oct 9, 2024

Short description 📝

stop generate empty TargetAttributes - because Xcode 16 will always remove such item

Solution 📦

very simple fix

NB! Better to wait for merging this fix first: fastlane/fastlane#23872

Copy link
Collaborator

@kwridan kwridan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this @Speakus

@pepicrft
Copy link
Contributor

pepicrft commented Dec 3, 2024

I added some tests. Thanks a lot @Speakus for your contribution 🙏🏼

@pepicrft
Copy link
Contributor

pepicrft commented Dec 3, 2024

@all-contributors add @Speakus for code

Copy link
Contributor

@pepicrft

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected token : in JSON at position 10330

@pepicrft pepicrft changed the title remove empty TargetAttributes from result pbxproj as Xcode 16 do each run fix: Inconsistent behaviour with Xcode 16 when PBXProject.TargetAttributes is empty Dec 3, 2024
@pepicrft pepicrft force-pushed the m.kholyavkin/IOSC-12423-fix-extra-changes branch from 3075f20 to dfdecc9 Compare December 3, 2024 15:20
@pepicrft pepicrft merged commit 7f92f6f into tuist:main Dec 3, 2024
5 of 6 checks passed
@pepicrft
Copy link
Contributor

pepicrft commented Dec 3, 2024

@all-contributors add @Speakus for code

Copy link
Contributor

@pepicrft

I've put up a pull request to add @Speakus! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants