Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add destroy method for graceful shutdown of worker pool #141

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

cdm6a
Copy link
Contributor

@cdm6a cdm6a commented Dec 6, 2023

I'm experiencing the following issue when running e2e tests using Jest:

Jest has detected the following 1 open handle potentially keeping Jest from exiting:

  ●  Piscina

    > 39 | import { transform } from 'camaro';
         | ^

      at new EventEmitterReferencingAsyncResource (node_modules/eventemitter-asyncresource/src/index.ts:23:5)
      at new EventEmitterAsyncResource (node_modules/eventemitter-asyncresource/src/index.ts:46:7)
      at new Piscina (node_modules/piscina/src/index.ts:893:5)
      at Object.<anonymous> (node_modules/camaro/index.js:13:12)

It appears a number of other folks may be running into this issue as well:

The goal of this PR is to provide a way to shutdown the worker pool in the event someone may be running into this.

@tuananh tuananh merged commit f4f260c into tuananh:develop Dec 11, 2023
61 checks passed
@tuananh
Copy link
Owner

tuananh commented Dec 11, 2023

Thanks. Will cut a release soon.

@cdm6a
Copy link
Contributor Author

cdm6a commented Jan 4, 2024

Hey @tuananh, did you happen to cut a release / publish this?

@tuananh
Copy link
Owner

tuananh commented Jan 6, 2024

Hey @tuananh, did you happen to cut a release / publish this?

I've published 6.2.2 to include this change https://www.npmjs.com/package/camaro?activeTab=versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants