-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental yaml input format #1842
Draft
jeromekelleher
wants to merge
2
commits into
tskit-dev:main
Choose a base branch
from
jeromekelleher:yaml-sim-ancestry
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
# | ||
# Copyright (C) 2021 University of Oxford | ||
# | ||
# This file is part of msprime. | ||
# | ||
# msprime is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# msprime is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with msprime. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
""" | ||
Define formats used for simulation input as JSON and related formats. | ||
""" | ||
from __future__ import annotations | ||
|
||
import copy | ||
import dataclasses | ||
import json | ||
|
||
import demes | ||
from ruamel.yaml import YAML | ||
|
||
import msprime | ||
|
||
|
||
@dataclasses.dataclass | ||
class SimulationConfig: | ||
ancestry_kwargs: dict | ||
mutations_kwargs: dict = None | ||
|
||
|
||
def parse_ancestry_json(data): | ||
data = copy.deepcopy(data) | ||
if "start_time" in data or "end_time" in data: | ||
raise ValueError( | ||
"specifying time values not currently supported as too confusing" | ||
) | ||
if "demography" in data: | ||
demes_dict = data["demography"] | ||
# TODO nasty going back to JSON here - can we make a demes.fromdict() | ||
# function to do this directly? | ||
demes_model = demes.loads(json.dumps(demes_dict), format="json") | ||
data["demography"] = msprime.Demography.from_demes(demes_model) | ||
return data | ||
|
||
|
||
def parse_mutations_json(data): | ||
|
||
if "start_time" in data or "end_time" in data: | ||
raise ValueError( | ||
"specifying time values not currently supported as too confusing" | ||
) | ||
return data | ||
|
||
|
||
def parse_yaml(text): | ||
|
||
yaml = YAML(typ="safe") | ||
data = yaml.load(text) | ||
config = SimulationConfig(parse_ancestry_json(data["ancestry"])) | ||
if "mutations" in data: | ||
config.mutations_kwargs = parse_mutations_json(data["mutations"]) | ||
return config |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
demes.Graph.fromdict()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! Thanks @grahamgower.