fix mongo version #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All of the tests and workflows are passing now. I did however have to rewrite some tests to allow that fallback behaviour since some mongo versions being tested are at the point where they only exist for older versions of ubuntu. |
|
Thank you for your contribution. Your commit have been merged and will be part of the next release. Have a nice day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 22.04 only have their own version for 6.0.4 and above, for any mongo version below that you have to download one for a lower Ubuntu version.
This PR fixes that but also adds better error checking for a bad status code when downloading, making it easier to find the root cause of the issue when one is to encounter something similar again.