Fix failure when setting NULL in UPDATE statement in JDBC-based connectors #24244
+37
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenjian2664
force-pushed
the
24204_pg
branch
from
38a5bbc
to
d78fb22
Compare
ebyhr
reviewed
Nov 25, 2024
| @@ -1868,6 +1868,10 @@ public void testConstantUpdateWithVarcharEqualityPredicates() | |||
| } | |||
| assertUpdate("UPDATE " + table.getName() + " SET col1 = 20 WHERE col2 = 'A'", 1); | |||
| assertQuery("SELECT * FROM " + table.getName(), "VALUES (1, 'a'), (20, 'A')"); | |||
|
|
|||
| // test update set to null | |||
| assertUpdate("UPDATE " + table.getName() + " SET col1 = null WHERE col2 = 'A'", 1); | |||
There was a problem hiding this comment.
A predicate isn't necessary for #24204 and we should test with all connectors. Please add a new test to BaseConnectorTest instead.
ebyhr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #24204
Release notes