Merge pull request #34 from trchudley/josseditorcomments

JOSS Editor Comments
trchudley · Oct 8, 2024 · dd0e816 · dd0e816
2 parents 40ec981 + 4b20b24
commit dd0e816
Show file tree

Hide file tree

Showing 6 changed files with 118 additions and 257 deletions.
diff --git a/images/example_mosaic_terrain.jpg b/images/example_mosaic_terrain.jpg
diff --git a/notebooks/flow_aware_hillshade.ipynb b/notebooks/flow_aware_hillshade.ipynb
diff --git a/notebooks/get_icebergs.ipynb b/notebooks/get_icebergs.ipynb
diff --git a/notebooks/mosaic_and_terrain.ipynb b/notebooks/mosaic_and_terrain.ipynb
diff --git a/notebooks/strip_search_and_dem_difference.ipynb b/notebooks/strip_search_and_dem_difference.ipynb
diff --git a/src/pdemtools/load.py b/src/pdemtools/load.py
@@ -348,10 +348,22 @@ def mosaic(
     else:
         dem = dems[0]
 
+    dems = None  # release dem objects for memory management
+
     # Filter -9999.0 values to np.nan
     dem = dem.where(dem > -9999.0)
 
-    dems = None  # release dem objects for memory management
+    # Enforce CF-compliant names
+    dem['x'].attrs['axis'] = 'X'
+    dem['x'].attrs['long_name'] = 'x coordinate of projection'
+    dem['x'].attrs['standard_name'] = 'projection_x_coordinate'
+    dem['x'].attrs['units'] = 'metre'
+
+    dem['y'].attrs['axis'] = 'Y'
+    dem['y'].attrs['long_name'] = 'y coordinate of projection'
+    dem['y'].attrs['standard_name'] = 'projection_y_coordinate'
+    dem['y'].attrs['units'] = 'metre'
+
     return dem