Skip to content

Commit

Permalink
[libcxx][CMake] Do not hard-code the ABI for the GPU build
Browse files Browse the repository at this point in the history
Summary:
We specify the ABI to experimental, but we should leave this up to the
user. Primarily this is because we want the ABI to be compatible with
the user's CPU build, so the default should be used.
  • Loading branch information
jhuber6 committed Sep 20, 2024
1 parent 2162a18 commit 6d66ac5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion libcxx/cmake/caches/AMDGPU.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Configuration options for libcxx.
set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "")
set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
set(LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "")
Expand Down
1 change: 0 additions & 1 deletion libcxx/cmake/caches/NVPTX.cmake
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# Configuration options for libcxx.
set(LIBCXX_ABI_VERSION 2 CACHE STRING "")
set(LIBCXX_CXX_ABI libcxxabi CACHE STRING "")
set(LIBCXX_ENABLE_EXCEPTIONS OFF CACHE BOOL "")
set(LIBCXX_ENABLE_FILESYSTEM OFF CACHE BOOL "")
Expand Down

0 comments on commit 6d66ac5

Please sign in to comment.